-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add correct binary for manager
and set runAsUser: 1000
in deployment.yaml
#313
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jokestax The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @aryan9600 |
|
||
COPY --from=builder /workspace/manager /manager | ||
|
||
RUN chmod +x /manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late reply,been travelling to attend Kubecon India 😅,and since we have used ./manger to start the controller,not sure why we dont need this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the manager binary is already executable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for sending this PR! needs a couple of changes.
|
||
COPY --from=builder /workspace/manager /manager | ||
|
||
RUN chmod +x /manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not.
Description:
This PR addresses the issue related to the missing
manager
binary in the Dockerfile and an error encountered due to user permissions in thedeployment.yaml
.Dockerfile Update:
manager
has been added to the Dockerfile as expected in line 38 of the deployment config.Deployment Update:
Added
runAsUser: 1000
to thedeployment.yaml
to resolve the permission error shown below:Testing
To test this change:
make build.image.controlplane
.kubectl apply -k config/default
to deploy the changes.