-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-scaffold the project for v0.4.0, removing the Golang control-plane #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
added
area/maintenance
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Sep 4, 2024
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Sep 4, 2024
shaneutt
force-pushed
the
shaneutt/v0.4.0-re-scaffolding
branch
from
September 4, 2024 21:31
c153043
to
d47d453
Compare
shaneutt
force-pushed
the
shaneutt/v0.4.0-re-scaffolding
branch
from
September 4, 2024 21:41
d47d453
to
fd1c2d9
Compare
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 4, 2024
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 5, 2024
shaneutt
force-pushed
the
shaneutt/v0.4.0-re-scaffolding
branch
from
September 5, 2024 13:48
c3494a7
to
0ebb6f3
Compare
shaneutt
added
the
tide/merge-method-rebase
Denotes a PR that should be rebased by tide when it merges.
label
Sep 5, 2024
shaneutt
force-pushed
the
shaneutt/v0.4.0-re-scaffolding
branch
2 times, most recently
from
September 6, 2024 21:17
ee9a290
to
803a7c6
Compare
Signed-off-by: Shane Utt <[email protected]>
The integration with bpfd is quite old, and in fact the project has since been renamed to bpfman. We have an open issue to add a bpfman integration, but in the meantime we can remove the old code. Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
shaneutt
force-pushed
the
shaneutt/v0.4.0-re-scaffolding
branch
from
September 12, 2024 12:55
803a7c6
to
0e5a589
Compare
aryan9600
approved these changes
Sep 16, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aryan9600, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaneutt
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/maintenance
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
tide/merge-method-rebase
Denotes a PR that should be rebased by tide when it merges.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yep, this PR is huge, sorry about that.
This cleans up the repository in several ways and removes the Golang control-plane in support of the upcoming v0.4.0 Milestone wherein we intend to switch to Rust for the control-plane.
This new foundation is intended to make the repository less confusing for newcomers and provide a bit more focus. It almost definitely breaks a couple of things here and there, however I would recommend we fix that forward rather than spend a lot of time here as the risk is zero for this project.
It does leave the Golang integration tests behind for a bit longer, as these are still useful as we continue to build the Rust control-plane to validate our new code.