Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run/fix DynamicPV tests in CI & remove redundant tests #189

Open
wongma7 opened this issue Jun 11, 2021 · 5 comments
Open

Run/fix DynamicPV tests in CI & remove redundant tests #189

wongma7 opened this issue Jun 11, 2021 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@wongma7
Copy link
Contributor

wongma7 commented Jun 11, 2021

/kind bug

What happened?
Old TODO: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/tests/e2e/conformance_test.go#L136

IIRC we are skipping the DynamicPV tests because of an issue in the framework where it would only wait 5 minutes for a volume to be created but that issue has been solved for a long time now.

Running them will allow us to refactor/get rid of some of the custom tests, for example 2/3 of the ones here https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/tests/e2e/dynamic_provisioning_test.go#L55, and maybe reduce some of the code duplicated from upstream like driver struct https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/tests/e2e/driver/driver.go#L23

(obviously this is blocked by CI being 100% broken at the moment)

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 11, 2021
@wongma7 wongma7 changed the title Run DynamicPV tests in CI & remove redundant tests Run/fix DynamicPV tests in CI & remove redundant tests Jun 11, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 11, 2021

since the script in #172 is creating a 1.20 cluster, need to fix #183

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 14, 2021

one more consideration is test time, they are slow since all tests involve creating an fsx volume (pre-provisioned the test calls aws api, dynamic the driver calls was api). Don't need to run the dynamic+pre-provisioned variation of every test. Maybe run all dynamic cases and run just 1 pre-provisioned case

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 17, 2021

Also , need to debug why a specific subPath test fails: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/Makefile#L51

@wongma7 wongma7 mentioned this issue Jun 17, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Oct 8, 2021

/lifecycle frozen

now that CI is fixed, should try to untangle dynamic PV tests

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants