Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commonize webhook validations at the some points #2054

Open
tenzen-y opened this issue Apr 10, 2024 · 6 comments · May be fixed by #2315
Open

Commonize webhook validations at the some points #2054

tenzen-y opened this issue Apr 10, 2024 · 6 comments · May be fixed by #2315
Assignees
@akagami-harsh
Labels
good first issue help wanted kind/feature

Comments

@tenzen-y
Copy link
Member

/kind feature

Based on this discussion (#2051 (comment)), after we complete the implementation of the webhook validations here (#1993), we should commonize duplicated validations like the podTemplate.
@tenzen-y tenzen-y mentioned this issue Apr 10, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member Author

/remove-lifecycle stale

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/remove-lifecycle stale
/good-first-issue

@google-oss-prow Google OSS Prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-lifecycle stale
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akagami-harsh
Copy link

/assign

@akagami-harsh akagami-harsh linked a pull request Oct 29, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akagami-harsh akagami-harsh

Labels
good first issue help wanted kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

commonize job name validation akagami-harsh/training-operator
3 participants
@andreyvelich @tenzen-y @akagami-harsh