Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding env vars #2285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding env vars #2285

wants to merge 1 commit into from

Conversation

tarekabouzeid
Copy link
Member

@tarekabouzeid tarekabouzeid commented Oct 16, 2024 •
edited
Loading

What this PR does / why we need it:

Enable users to set environment variables to init and worker containers. Used same implementation in Katib here

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2284

Checklist:

  • Docs included if any changes are user facing

@tarekabouzeid
adding env vars
652a0d5 
Signed-off-by: Tarek Abouzeid <[email protected]>

using same implementation in katib

Signed-off-by: Tarek Abouzeid <[email protected]>

updating docs

Signed-off-by: Tarek Abouzeid <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jinchihe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11360686311

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 11330381194: 0.0%
Covered Lines: 66
Relevant Lines: 66
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add environment variables to containers
2 participants
@tarekabouzeid @coveralls