From 58d8587994c070f5ff6686cc96740af16f2918e5 Mon Sep 17 00:00:00 2001 From: Yuki Iwai Date: Sun, 3 Nov 2024 05:50:26 +0900 Subject: [PATCH] Rename Completed to Complete Signed-off-by: Yuki Iwai --- docs/proposals/2170-kubeflow-training-v2/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/proposals/2170-kubeflow-training-v2/README.md b/docs/proposals/2170-kubeflow-training-v2/README.md index e5cc4bcfd9..b5f281d809 100644 --- a/docs/proposals/2170-kubeflow-training-v2/README.md +++ b/docs/proposals/2170-kubeflow-training-v2/README.md @@ -284,7 +284,7 @@ const ( TrainJobSuspended string = "Suspended" // TrainJobCompleted means that the TrainJob has completed its execution. - TrainJobCompleted string = "Completed" + TrainJobCompleted string = "Complete" // TrainJobFailed means that the actual jobs have failed its execution. TrainJobFailed string = "Failed" @@ -958,7 +958,7 @@ spec: In this section, we're explaining the TrainJob state transition (`.status.conditions`). The basic TrainJob state machine is the below. Especially, if we specify the TrainingRuntime or ClusterTrainingRuntime as a runtime, -the TrainJob terminal condition (`Failed` or `Completed`) is decided based on the JobSet terminal state (`status.terminalState`) +the TrainJob terminal condition (`Failed` or `Complete`) is decided based on the JobSet terminal state (`status.terminalState`) instead of computing from JobSet conditions. ```mermaid @@ -986,8 +986,8 @@ stateDiagram-v2 Failed=True --> [*] #COMPLETION - terminal_choice --> Completed=True: Actual Jobs (e.g., JobSet) completed. - Completed=True --> [*] + terminal_choice --> Complete=True: Actual Jobs (e.g., JobSet) completed. + Complete=True --> [*] ``` In the above state transition, the `Created=False` will happen in the following situations and