Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix ci-passed label update on PR synchronization #11358

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

VaniHaripriya
Copy link
Contributor

Description of your changes:

  • This PR addresses the issue with adding ci-passed label during PR Synchronization. Reference PR #11354
  • The issue was caused by the parallel execution of the reset_ci_passed_label and add_ci_passed_label steps in the "Add CI Passed Label" GitHub Action workflow.
  • The workflow has been updated to execute the reset_ci_passed_label and add_ci_passed_label steps sequentially, ensuring that the ci-passed label is correctly added on PR synchronization.

Checklist:

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9a9cf73 into kubeflow:master Nov 5, 2024
3 checks passed
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants