Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nikhil/cncfbloglinkfix #373

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Nikhil/cncfbloglinkfix #373

merged 5 commits into from
Aug 7, 2023

Conversation

nikhilchauhangithub
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • [x ] The commit message follows our guidelines
  • [x ] Tests for the changes have been added (for bug fixes / features)
  • [x ] Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    blog docs broken linkfix

issue #372

@nikhilchauhangithub
slsa hyperlink fix
82435a8 
Signed-off-by: nikhilchauhangithub <[email protected]>
@nikhilchauhangithub
slsa github generator link fix
181b09b 
Signed-off-by: nikhilchauhangithub <[email protected]>
@nikhilchauhangithub
all link fix in zh blog page
1db2d05 
Signed-off-by: nikhilchauhangithub <[email protected]>
@nikhilchauhangithub
fixed link
6ae1a83 
Signed-off-by: nikhilchauhangithub <[email protected]>
@nikhilchauhangithub
All possible broken link fix
5664446 
Signed-off-by: nikhilchauhangithub <[email protected]>
@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2023
@nikhilchauhangithub
Copy link
Contributor Author

@anvithks @edisonxiang here i fixed all possible broken links, kindly review them

Arhell
Arhell reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
anvithks
anvithks approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kevin-wangzefeng
Copy link
Member

/lgtm
/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anvithks, kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@kubeedge-bot kubeedge-bot merged commit d66b1eb into kubeedge:master Aug 7, 2023
@kevin-wangzefeng kevin-wangzefeng mentioned this pull request Aug 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@anvithks anvithks anvithks approved these changes

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

Assignees

@kevin-wangzefeng kevin-wangzefeng

@anvithks anvithks

@Arhell Arhell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikhilchauhangithub @kevin-wangzefeng @kubeedge-bot @anvithks @Arhell