Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pgpool Complete Docs #650

Merged
merged 16 commits into from
Aug 14, 2024
Merged

Add Pgpool Complete Docs #650

merged 16 commits into from
Aug 14, 2024

Conversation

MobarakHsn
Copy link
Contributor

Signed-off-by: MobarakHsn [email protected]

@MobarakHsn MobarakHsn force-pushed the pgpool branch 2 times, most recently from 408e803 to c0cbeaf Compare July 16, 2024 09:13
@MobarakHsn MobarakHsn force-pushed the pgpool branch 6 times, most recently from 3ad50c5 to 94fe234 Compare July 31, 2024 07:08
@MobarakHsn MobarakHsn requested a review from raihankhan July 31, 2024 07:42
@kubedb kubedb deleted a comment from github-actions bot Aug 1, 2024
@kubedb kubedb deleted a comment from gitguardian bot Aug 1, 2024
@gitguardian GitGuardian
Copy link

gitguardian bot commented Aug 1, 2024 •
edited
Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13066657 Triggered RSA Private Key d482bc1 docs/guides/pgpool/tls/configure_ssl.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 479cc28):

https://kubedb-v2-hugo--pr650-pgpool-cd0pndwl.web.app

(expires Wed, 21 Aug 2024 09:47:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943

@MobarakHsn MobarakHsn force-pushed the pgpool branch 2 times, most recently from 66614fb to 20d8e73 Compare August 1, 2024 10:04
raihankhan
raihankhan requested changes Aug 13, 2024
View reviewed changes
docs/guides/pgpool/reconfigure/overview.md

8. Then the `KubeDB` Ops-manager operator will restart the related PetSet Pods so that they restart with the new configuration defined in the `PgpoolOpsRequest` CR.

9. After the successful reconfiguring of the `Pgpool`, the `KubeDB` Ops-manager operator resumes the `Pgpool` object so that the `KubeDB` Provisioner operator resumes its usual operations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines are broken. Re-check them. Happens in all the overviews.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seems some internal issues to all the DB docs. Locally in goland all seems fine!

docs/guides/pgpool/scaling/horizontal-scaling/horizontal-ops.md Outdated
menu:
docs_{{ .version }}:
identifier: pp-horizontal-scaling-ops
name: pp-horizontal-scaling-ops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the name here - HorizontalScaling OpsRequest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/guides/pgpool/scaling/vertical-scaling/vertical-ops.md Outdated
menu:
docs_{{ .version }}:
identifier: pp-vertical-scaling-ops
name: pp-vertical-scaling-ops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the name here - VerticalScaling OpsRequest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/guides/pgpool/configuration/using-config-file.md Outdated
menu:
docs_{{ .version }}:
identifier: pp-using-config-file-configuration
name: Config File
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename - Customize Configurations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/guides/pgpool/configuration/using-init-config.md Outdated
menu:
docs_{{ .version }}:
identifier: pp-using-init-configuration
name: Init Config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename - Customize Init Config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

docs/guides/pgpool/configuration/using-podtemplate.md


## CRD Configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some more example -

  1. Refer to this blog for adding custom sidecar containers - custom container

  2. Using nodeselector

  3. Using taint and tolerations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@MobarakHsn @raihankhan
Pgpool docs
3e19f91 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Add pgpool ops-request, auto-scaling
df94c8b 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Add pgpool monitoring
43d9dbc 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
update image
3008aba 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Pgpool tls related docs
d482bc1 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Pgpool autoscaler,ops-req
a78955f 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Add pgpool reconfigure-tls
a385044 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Add image
0e92b5c 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Pgpool configuration
ba7551c 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn @raihankhan
Pgpool configure and reconfigure
d7d3767 
Signed-off-by: MobarakHsn <[email protected]>
@MobarakHsn MobarakHsn requested a review from raihankhan August 14, 2024 09:51
raihankhan
raihankhan approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@raihankhan raihankhan merged commit e19f4b4 into master Aug 14, 2024
6 checks passed
@raihankhan raihankhan deleted the pgpool branch August 14, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raihankhan raihankhan raihankhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MobarakHsn @raihankhan