Skip to content

Commit

Permalink
add review changes
Browse files Browse the repository at this point in the history 
Signed-off-by: Neaj Morshad <[email protected]>
  • Loading branch information
@Neaj-Morshad-101
Neaj-Morshad-101 committed Nov 4, 2024
1 parent 336f63b commit dc90be5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 29 deletions.
22 changes: 0 additions & 22 deletions docs/guides/mssqlserver/autoscaler/compute/cluster.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -553,28 +553,6 @@ Status:
Type: Successful
Observed Generation: 1
Phase: Successful
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Normal Starting 12m KubeDB Ops-manager Operator Start processing for MSSQLServerOpsRequest: demo/msops-mssqlserver-ag-cluster-8li26q
Normal Starting 12m KubeDB Ops-manager Operator Pausing MSSQLServer database: demo/mssqlserver-ag-cluster
Normal Successful 12m KubeDB Ops-manager Operator Successfully paused MSSQLServer database: demo/mssqlserver-ag-cluster for MSSQLServerOpsRequest: msops-mssqlserver-ag-cluster-8li26q
Normal UpdatePetSets 12m KubeDB Ops-manager Operator Successfully updated PetSets Resources
Warning get pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-0 12m KubeDB Ops-manager Operator get pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-0
Warning evict pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-0 12m KubeDB Ops-manager Operator evict pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-0
Warning check pod running; ConditionStatus:False; PodName:mssqlserver-ag-cluster-0 12m KubeDB Ops-manager Operator check pod running; ConditionStatus:False; PodName:mssqlserver-ag-cluster-0
Warning check pod running; ConditionStatus:True; PodName:mssqlserver-ag-cluster-0 11m KubeDB Ops-manager Operator check pod running; ConditionStatus:True; PodName:mssqlserver-ag-cluster-0
Warning get pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-1 11m KubeDB Ops-manager Operator get pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-1
Warning evict pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-1 11m KubeDB Ops-manager Operator evict pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-1
Warning check pod running; ConditionStatus:False; PodName:mssqlserver-ag-cluster-1 11m KubeDB Ops-manager Operator check pod running; ConditionStatus:False; PodName:mssqlserver-ag-cluster-1
Warning check pod running; ConditionStatus:True; PodName:mssqlserver-ag-cluster-1 11m KubeDB Ops-manager Operator check pod running; ConditionStatus:True; PodName:mssqlserver-ag-cluster-1
Warning get pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-2 11m KubeDB Ops-manager Operator get pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-2
Warning evict pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-2 11m KubeDB Ops-manager Operator evict pod; ConditionStatus:True; PodName:mssqlserver-ag-cluster-2
Warning check pod running; ConditionStatus:False; PodName:mssqlserver-ag-cluster-2 11m KubeDB Ops-manager Operator check pod running; ConditionStatus:False; PodName:mssqlserver-ag-cluster-2
Warning check pod running; ConditionStatus:True; PodName:mssqlserver-ag-cluster-2 10m KubeDB Ops-manager Operator check pod running; ConditionStatus:True; PodName:mssqlserver-ag-cluster-2
Normal RestartPods 10m KubeDB Ops-manager Operator Successfully Restarted Pods With Resources
Normal Starting 10m KubeDB Ops-manager Operator Resuming MSSQLServer database: demo/mssqlserver-ag-cluster
Normal Successful 10m KubeDB Ops-manager Operator Successfully resumed MSSQLServer database: demo/mssqlserver-ag-cluster for MSSQLServerOpsRequest: msops-mssqlserver-ag-cluster-8li26q
```

Now, we are going to verify from the Pod, and the MSSQLServer yaml whether the resources of the cluster database has updated to meet up the desired state, Let's check,
Expand Down
14 changes: 7 additions & 7 deletions docs/guides/mssqlserver/autoscaler/storage/cluster.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ Now, wait until `mssqlserver-ag-cluster` has status `Ready`. i.e,
```bash
$ kubectl get mssqlserver -n demo
NAME VERSION STATUS AGE
mssqlserver-ag-cluster 2022-cu12 Ready 89m
mssqlserver-ag-cluster 2022-cu12 Ready 4m
```

Let's check volume size from petset, and from the persistent volume,
Expand All @@ -171,9 +171,9 @@ $ kubectl get petset -n demo mssqlserver-ag-cluster -o json | jq '.spec.volumeCl
$ kubectl get pv -n demo
NAME CAPACITY ACCESS MODES RECLAIM POLICY STATUS CLAIM STORAGECLASS VOLUMEATTRIBUTESCLASS REASON AGE
pvc-1497dd6d-9cbd-467a-8e0c-c3963ce09e1b 1Gi RWO Delete Bound demo/data-mssqlserver-ag-cluster-1 longhorn <unset> 88m
pvc-37a7bc8d-2c04-4eb4-8e53-e610fd1daaf5 1Gi RWO Delete Bound demo/data-mssqlserver-ag-cluster-0 longhorn <unset> 88m
pvc-817866af-5277-4d51-8d81-434e8ec1c442 1Gi RWO Delete Bound demo/data-mssqlserver-ag-cluster-2 longhorn <unset> 88m
pvc-1497dd6d-9cbd-467a-8e0c-c3963ce09e1b 1Gi RWO Delete Bound demo/data-mssqlserver-ag-cluster-1 longhorn <unset> 8m
pvc-37a7bc8d-2c04-4eb4-8e53-e610fd1daaf5 1Gi RWO Delete Bound demo/data-mssqlserver-ag-cluster-0 longhorn <unset> 8m
pvc-817866af-5277-4d51-8d81-434e8ec1c442 1Gi RWO Delete Bound demo/data-mssqlserver-ag-cluster-2 longhorn <unset> 8m
```

You can see the petset has 1GB storage, and the capacity of all the persistent volume is also 1GB.
Expand Down Expand Up @@ -433,9 +433,9 @@ $ kubectl get petset -n demo mssqlserver-ag-cluster -o json | jq '.spec.volumeCl
"1531054080"
$ kubectl get pv -n demo
NAME CAPACITY ACCESS MODES RECLAIM POLICY STATUS CLAIM STORAGECLASS VOLUMEATTRIBUTESCLASS REASON AGE
pvc-2ff83356-1bbc-44ab-99f1-025e3690a471 1462Mi RWO Delete Bound demo/data-mssqlserver-ag-cluster-2 longhorn <unset> 3h50m
pvc-a5cc0ae9-2c8d-456c-ace2-fc4fafc6784f 1462Mi RWO Delete Bound demo/data-mssqlserver-ag-cluster-1 longhorn <unset> 3h51m
pvc-e8ab47a4-17a6-45fb-9f39-e71a03498ab5 1462Mi RWO Delete Bound demo/data-mssqlserver-ag-cluster-0 longhorn <unset> 3h51m
pvc-2ff83356-1bbc-44ab-99f1-025e3690a471 1462Mi RWO Delete Bound demo/data-mssqlserver-ag-cluster-2 longhorn <unset> 15m
pvc-a5cc0ae9-2c8d-456c-ace2-fc4fafc6784f 1462Mi RWO Delete Bound demo/data-mssqlserver-ag-cluster-1 longhorn <unset> 16m
pvc-e8ab47a4-17a6-45fb-9f39-e71a03498ab5 1462Mi RWO Delete Bound demo/data-mssqlserver-ag-cluster-0 longhorn <unset> 16m
```

The above output verifies that we have successfully autoscaled the volume of the MSSQLServer cluster database.
Expand Down

0 comments on commit dc90be5

Please sign in to comment.