Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload config involves a loss of logs #791

Open
sebastiendejou opened this issue Jul 20, 2021 · 2 comments
Open

Reload config involves a loss of logs #791

sebastiendejou opened this issue Jul 20, 2021 · 2 comments
Labels
Milestone

Comments

@sebastiendejou
Copy link

Is your feature request related to a problem? Please describe.

When an update of the fluentd's configuration happens from another namespace, the fluentd worker process is restarted. (this way : http://127.0.0.1:24444/api/config.reload) and the problem happens : Logs are lost during reload for the first namespace.
Does logging-operator respect the multitenancy agreement ?

Describe alternatives you've considered
No one.

Describe alternatives you've considered
In a previous issue, "/api/config.gracefulReload" (#454) has been suggested. This issue has been merged, but reverted after that.
Is there a mechanism that could gracefully reload the fluentd ?

Regards

@pepov
Copy link
Member

pepov commented Jul 26, 2021

It was reverted because it did not handle plugin params as expected. Things might have changed with latest fluentd versions though. I would consider making this configurable and let users experiment with it until we can get back to this and retest it thoroughly.

@stale stale bot added the wontfix This will not be worked on label Apr 12, 2023
@aslafy-z aslafy-z removed the wontfix This will not be worked on label Apr 14, 2023
@stale stale bot added the wontfix This will not be worked on label Jun 13, 2023
@pepov pepov added fluentd enhancement New feature or request and removed wontfix This will not be worked on labels Jun 14, 2023
@pepov pepov added this to the 4.3 milestone Jun 14, 2023
@pepov pepov modified the milestones: 4.3, 4.x Jul 4, 2023
@pepov pepov added the good first issue Good for newcomers label Aug 8, 2023
@stale stale bot added the wontfix This will not be worked on label Oct 7, 2023
@aslafy-z aslafy-z added the pinned label Oct 7, 2023
@stale stale bot removed the wontfix This will not be worked on label Oct 7, 2023
@pepov
Copy link
Member

pepov commented Oct 7, 2024

@sebastiendejou or anyone else still have any interest in trying gracefulReload? If yes we can implement a flag for that.

@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@csatib02 csatib02 modified the milestones: 5.x, Fluentd Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants