Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Cluster autoscaler labels/taints per nodepool #982

Closed
Silvest89 opened this issue Sep 15, 2023 · 3 comments
Closed

[Feature Request]: Cluster autoscaler labels/taints per nodepool #982

Silvest89 opened this issue Sep 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Silvest89
Copy link
Contributor

Description

Would be nice to be able to set different taints/labels per autoscaler nodepool

@ricristian
Copy link
Contributor

ricristian commented Sep 17, 2023

You already have this option in kube.tf.example or I am missing something ?

https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/blob/master/kube.tf.example#L269C2-L280C1

@Silvest89
Copy link
Contributor Author

@ricristian Yes but if you set it there it goes for all autoscaler node pools.

Something like this would be nice

  autoscaler_nodepools = [
    {
      name        = "autoscaled-small"
      server_type = "cpx11"
      location    = "fsn1"
      min_nodes   = 0
      max_nodes   = 1
      labels = []
      taints = []
    }
  ]

@Silvest89
Copy link
Contributor Author

Implemented in #1012
Waiting for upstream autoscaler

@mysticaltech mysticaltech added the enhancement New feature or request label Oct 17, 2023
@kube-hetzner kube-hetzner locked and limited conversation to collaborators Oct 18, 2023
@mysticaltech mysticaltech converted this issue into discussion #1040 Oct 18, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants