Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a URL Builder for scrapping timetable #4

Open
kshitij10496 opened this issue Oct 17, 2018 · 4 comments
Open

Create a URL Builder for scrapping timetable #4

kshitij10496 opened this issue Oct 17, 2018 · 4 comments
Labels
easy Beginner friendly hacktoberfest I won't be able to sponsor shirts, but I can help you enjoy contributing to Open Source scrapping Issues related to data scrapping

Comments

@kshitij10496
Copy link
Owner

Find the best solution to creating the URL required for scrapping Timetable data from ERP.

Refer: /data/scrapper/course_rooms.py

@kshitij10496 kshitij10496 added hacktoberfest I won't be able to sponsor shirts, but I can help you enjoy contributing to Open Source scrapping Issues related to data scrapping easy Beginner friendly labels Oct 17, 2018
@icyflame
Copy link
Collaborator

@kshitij10496 Can you mention a couple of reasons you are not happy with the present string formatting solution? It looks good to me, and gives a pretty high degree of flexibility when the URLs change in the future.

@kshitij10496
Copy link
Owner Author

@kshitij10496 Can you mention a couple of reasons you are not happy with the present string formatting solution? It looks good to me, and gives a pretty high degree of flexibility when the URLs change in the future.

I just don't think string formatting is the best way to create URLs in Go.
Ideally, we should use URL type with query parameters.

@icyflame
Copy link
Collaborator

In Go? The course scrapper is written in Python though. ❓

@kshitij10496
Copy link
Owner Author

My bad! 😅
What I meant was that string formatting, in general, is not the best way to create URLs, something that I learnt in Go. Hence, we should use the standard library whenever it comes to manipulating URLs.
Having said that, I think of this as a nice to have, non-blocking feature which can help people get started contributing. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Beginner friendly hacktoberfest I won't be able to sponsor shirts, but I can help you enjoy contributing to Open Source scrapping Issues related to data scrapping
Projects
None yet
Development

No branches or pull requests

2 participants