Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Labour#1]: Port wimp to use hercules #17

Open
kshitij10496 opened this issue Oct 19, 2018 · 5 comments
Open

[Labour#1]: Port wimp to use hercules #17

kshitij10496 opened this issue Oct 19, 2018 · 5 comments
Labels
hacktoberfest I won't be able to sponsor shirts, but I can help you enjoy contributing to Open Source herculean-task The Labours of Hercules

Comments

@kshitij10496
Copy link
Owner

@themousepotato Can you experiment with using hercules API to power wimp?
Given that the endpoints currently have bare minimum documentation, I would be happy to assist you. 😄

cc @icyflame @amrav

@kshitij10496 kshitij10496 added hacktoberfest I won't be able to sponsor shirts, but I can help you enjoy contributing to Open Source herculean-task The Labours of Hercules labels Oct 19, 2018
@themousepotato
Copy link
Collaborator

I've already opened an issue metakgp/wimp#39 4 days ago and was waiting for someone to take it. :D I can't think of myself doing that. It'll delete most of my code :(

@kshitij10496
Copy link
Owner Author

I can't think of myself doing that. It'll delete most of my code :(

Yes, I agree with the fact that most of the scrapping logic in wimp would become redundant. 😢
Having said that, I believe that hercules would make the project extensible and take a lot of load off of your shoulders. Moreover, the integration would help develop a better understanding of dealing with JSON APIs in Python, specifically related to making requests and decoding responses. 😅

@themousepotato
Copy link
Collaborator

Will definitely work on this sometime, then @kshitij10496 :)

@icyflame
Copy link
Collaborator

@themousepotato Getting to delete old code and write new, better code is always a privilege! In these projects, we have the time and resources to re-write stuff well, that's a great opportunity. I often learn a lot about the mistakes I made the first time around whenever I do a re-write of something I made (eg: bar-horizontal and cli-cube-timer, I wrote both before I knew what Node was really for, and after doing Node for a couple years, I re-wrote them! Couldn't believe the kind of Node I used to write!) If you get the chance to, you should definitely be the one to re-write wimp!

@themousepotato
Copy link
Collaborator

Sure @icyflame :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest I won't be able to sponsor shirts, but I can help you enjoy contributing to Open Source herculean-task The Labours of Hercules
Projects
None yet
Development

No branches or pull requests

3 participants