refactor: Omit local types

krille-chan · Jul 4, 2024 · ef5ea57 · ef5ea57
1 parent e88afdd
commit ef5ea57
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 9 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -9,6 +9,7 @@ linter:
     - prefer_final_in_for_each
     - sort_pub_dependencies
     - require_trailing_commas
+    - omit_local_variable_types
 
 analyzer:
   errors:

diff --git a/lib/pages/chat/chat_emoji_picker.dart b/lib/pages/chat/chat_emoji_picker.dart
@@ -14,7 +14,7 @@ class ChatEmojiPicker extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final ThemeData theme = Theme.of(context);
+    final theme = Theme.of(context);
     return AnimatedContainer(
       duration: FluffyThemes.animationDuration,
       curve: FluffyThemes.animationCurve,

diff --git a/lib/pages/chat/event_info_dialog.dart b/lib/pages/chat/event_info_dialog.dart
@@ -28,8 +28,8 @@ class EventInfoDialog extends StatelessWidget {
   });
 
   String get prettyJson {
-    const JsonDecoder decoder = JsonDecoder();
-    const JsonEncoder encoder = JsonEncoder.withIndent('    ');
+    const decoder = JsonDecoder();
+    const encoder = JsonEncoder.withIndent('    ');
     final object = decoder.convert(jsonEncode(event.toJson()));
     return encoder.convert(object);
   }

diff --git a/lib/pages/chat/input_bar.dart b/lib/pages/chat/input_bar.dart
@@ -55,7 +55,7 @@ class InputBar extends StatelessWidget {
     }
     final searchText =
         controller!.text.substring(0, controller!.selection.baseOffset);
-    final List<Map<String, String?>> ret = <Map<String, String?>>[];
+    final ret = <Map<String, String?>>[];
     const maxResults = 30;
 
     final commandMatch = RegExp(r'^/(\w*)$').firstMatch(searchText);

diff --git a/lib/pages/chat/send_file_dialog.dart b/lib/pages/chat/send_file_dialog.dart
@@ -64,7 +64,7 @@ class SendFileDialogState extends State<SendFileDialog> {
   @override
   Widget build(BuildContext context) {
     var sendStr = L10n.of(context)!.sendFile;
-    final bool allFilesAreImages =
+    final allFilesAreImages =
         widget.files.every((file) => file is MatrixImageFile);
     final sizeString = widget.files
         .fold<double>(0, (p, file) => p + file.bytes.length)

diff --git a/lib/pages/chat_list/client_chooser_button.dart b/lib/pages/chat_list/client_chooser_button.dart
@@ -165,7 +165,7 @@ class ClientChooserButton extends StatelessWidget {
   Widget build(BuildContext context) {
     final matrix = Matrix.of(context);
 
-    int clientCount = 0;
+    var clientCount = 0;
     matrix.accountBundles.forEach((key, value) => clientCount += value.length);
     return FutureBuilder<Profile>(
       future: matrix.client.fetchOwnProfile(),
@@ -292,7 +292,7 @@ class ClientChooserButton extends StatelessWidget {
       );
     // beginning from end if negative
     if (index < 0) {
-      int clientCount = 0;
+      var clientCount = 0;
       matrix.accountBundles
           .forEach((key, value) => clientCount += value.length);
       _handleKeyboardShortcut(matrix, clientCount, context);
@@ -312,7 +312,7 @@ class ClientChooserButton extends StatelessWidget {
   }
 
   int? _shortcutIndexOfClient(MatrixState matrix, Client client) {
-    int index = 0;
+    var index = 0;
 
     final bundles = matrix.accountBundles.keys.toList()
       ..sort(

diff --git a/lib/utils/matrix_sdk_extensions/flutter_hive_collections_database.dart b/lib/utils/matrix_sdk_extensions/flutter_hive_collections_database.dart
@@ -82,7 +82,7 @@ class FlutterHiveCollectionsDatabase extends HiveCollectionsDatabase {
   }
 
   static Future<String> findDatabasePath(Client client) async {
-    String path = client.clientName;
+    var path = client.clientName;
     if (!kIsWeb) {
       Directory directory;
       try {