Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Backpack interface for typerep-map #54

Open
chshersh opened this issue Sep 21, 2018 · 2 comments
Open

Add Backpack interface for typerep-map #54

chshersh opened this issue Sep 21, 2018 · 2 comments

Comments

@chshersh
Copy link
Contributor

Especially useful when we will expose Map-based solution. This will also allow us to refactor tests and benchmarks. We don't need to implement all functions for every solution, for non-interesting one in the internal library we can just have error "Not supported by this implementation!".

Issues on refactoring benchmarks and tests will be open only after this issue is done.

@vrom911
Copy link
Member

vrom911 commented Sep 21, 2018

Do I understand this correctly that this change makes typerep-map library unusable with stack?

@chshersh
Copy link
Contributor Author

@vrom911 Unfortunately, yes, untill stack adds support for Backpack. Transition to Backpack will break typerep-map into multiple packages:

  • typerep-map-sig: Backpack signatures
  • typerep-map-containers: containers-based solution
  • typerep-map: array-based solution (same name for backwards compatibility reasons)

It's possible to implement benchmarks and tests in separate packages to have typerep-map-containers and typerep-map packages build with stack but don't want to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants