Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stan should normalize incoming file paths to be relative #556

Open
keithfancher opened this issue Feb 3, 2024 · 3 comments
Open

Stan should normalize incoming file paths to be relative #556

keithfancher opened this issue Feb 3, 2024 · 3 comments

Comments

@keithfancher
Copy link

Related to the HLS issue haskell/haskell-language-server#3174 and its associated PR haskell/haskell-language-server#4023.

Stan's checksMap and createCabalExtensionsMap use relative paths, but Stan will happily take absolute paths for queried HIE files. Paths coming in from HLS, for example, were absolute, causing Map misses and resulting in the above issue. The result of these misses is that Stan didn't detect any enabled language extensions, and, e.g., would spam the user with suggestions to enable StrictData.

I would suggest normalizing incoming files, ensuring they're relative as expected, to avoid issues like this in the future. And/or documenting that Stan expects relative paths.

Thank you!

@tomjaguarpaw
Copy link
Collaborator

Thanks for the report. stan and extensions have very little active maintainership currently. I'm happy to oversee and advise a patch to fix this, but I won't have time to do it myself any time in the near future. Perhaps @0rphee is interested?

@tomjaguarpaw
Copy link
Collaborator

The first thing to do would be to produce an example that demonstrates the current behaviour, as simply as possible.

@0rphee
Copy link
Contributor

0rphee commented Feb 6, 2024

Probably I won't be able to work on this for the foreseeable future, maybe in a few months.. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants