Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport MonadError(..) from Relude.Monad.Reexport #460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexbiehl
Copy link
Contributor

@alexbiehl alexbiehl commented Oct 6, 2024

Resolves #444

In our code base we are using a lot of ExceptT an runExcept. But unfortunately throwError requires an additional import.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@alexbiehl alexbiehl changed the title Reexport throwError from Relude.Monad.Reexport Reexport MonadError(..) from Relude.Monad.Reexport Oct 6, 2024
@tomjaguarpaw
Copy link
Contributor

Hello @alexbiehl, thanks for your PR. I am an assistant maintainer for the Kowainik ecosystem. Currently most of the Kowainki ecosystem, including Relude, is in emergency maintenance only mode and not accepting new features and I think it's unlikely this PR will be merged (@vrom911 might overrule me, of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MonadError not reexported
2 participants