Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from REST API to GraphQL API #214

Open
12 tasks
chshersh opened this issue Feb 11, 2021 · 0 comments
Open
12 tasks

Migrate from REST API to GraphQL API #214

chshersh opened this issue Feb 11, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request GitHub GitHub API refactoring

Comments

@chshersh
Copy link
Contributor

chshersh commented Feb 11, 2021

We can attempt to migrate to a newer API after the following issue in github-graphql is implemented:

Since we will write a lot of custom queries for GitHub, I propose the following new module structure:

  • Replace Hit.Issue with Hit.GitHub.Issue + Hit.GitHub.PullRequest + Hit.GitHub.Milestone + Hit.GitHub.Fork
  • Each module will contain queries, types with FromJSON instances and functions to fetch relevant information

Once the migration is done, we need to test that our code still works as expected. User-stories to test (feel free to add more):

  • Fetch single issue and display all info
  • Fetch all issues
  • Fetch issue and filter by login
  • Fetch issue and filter by milestone
  • Fetch issue and filter by both login and milestone
  • Fetch only issue title
  • Fetch the latest milestone
  • Fetch all milestones
  • Assign to the existing issue
  • Create a new issue with the assignment
  • Fork
  • Create a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GitHub GitHub API refactoring
Projects
None yet
Development

No branches or pull requests

2 participants