Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API errors handling is incorrect #1

Open
olegwtf opened this issue Dec 4, 2017 · 0 comments
Open

API errors handling is incorrect #1

olegwtf opened this issue Dec 4, 2017 · 0 comments

Comments

@olegwtf
Copy link

olegwtf commented Dec 4, 2017

There is no error object in JSON received from API, so I got python exception instead of correct exception: https://github.com/koty/python-stackpath/blob/master/stackpath/stackpath.py#L75-L77

This should be resp['status'] and resp['error']
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olegwtf