Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move code Escape button keyListener to better place #79

Open
kordwarshuis opened this issue Nov 17, 2020 · 2 comments
Open

move code Escape button keyListener to better place #79

kordwarshuis opened this issue Nov 17, 2020 · 2 comments
Assignees
@kordwarshuis
Labels
enhancement New feature or request
Milestone
Next week

Comments

@kordwarshuis
Copy link
Owner

Escape button keyListener is closing all modals.
This is desired behaviour but the location and structure of the code is not ok and in a confusion location
@kordwarshuis kordwarshuis added the enhancement New feature or request label Nov 17, 2020
@kordwarshuis kordwarshuis self-assigned this Nov 17, 2020
@henkvancann
Copy link
Contributor

This a code-technical bug, that at some point in time is going to nag us.
Prio = high
Urgency = low

@henkvancann
Copy link
Contributor

related to #62

@kordwarshuis kordwarshuis added this to the Next week milestone Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kordwarshuis kordwarshuis

Labels
enhancement New feature or request
Projects
None yet
Milestone
Next week
Development

No branches or pull requests
2 participants
@henkvancann @kordwarshuis