feat(RHTAPREL-618): create two repos when pushing to registry.redhat.io #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalina
requested review from
a team,
theflockers,
davidmogar,
scoheb,
johnbieren,
jinqi7,
cuipinghuo and
Troy876
and removed request for
a team
mmalina
force-pushed
the
pyxis-image-repos
branch
2 times, most recently
from
33426fd to
6a00be6
Compare
happybhati
approved these changes
Nov 1, 2023
No idea, ask Johnny :D I just cloned the other entry and changed what needed changing. |
The good old days 😂 |
Based on discussion with rbean and jvulgan in Slack, we should actually create two items in ContainerImage.repositories for images pushed to registry.redhat.io. The first one will be the same as for other pushes. The second one will have the registry and repository values converted (see the Python script documentation for more details). The quay.io entry will be used for pulling the image for grading of the image by Clair. Signed-off-by: Martin Malina <[email protected]>
mmalina
force-pushed
the
pyxis-image-repos
branch
from
6a00be6 to
52a99d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion with rbean and jvulgan in Slack, we should actually create two items in ContainerImage.repositories for images pushed to registry.redhat.io. The first one will be the same as for other pushes. The second one will have the registry and repository values converted (see the Python script documentation for more details).
The quay.io entry will be used for pulling the image for grading of the image by Clair.