fix(marketplacesvm): path regex #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
approved these changes
Dec 9, 2024
JAVGan
force-pushed
the
fix_marketplacesvm_wrapper
branch
from
351bcfe to
ad94ba0
Compare
|
/ok-to-test |
|
Any sggestions for gitlint? I'm still not very used to that |
|
I think it is the Update vs update in commit title |
|
nvm your commit title isn't the pr title. I think it is the missing |
JAVGan
changed the title
This commit updates the regex patter for validating the staged directory path string. Signed-off-by: Jonathan Gangi <[email protected]>
JAVGan
force-pushed
the
fix_marketplacesvm_wrapper
branch
from
ad94ba0 to
6f1f455
Compare
|
/ok-to-test |
|
You want this merged once it passes CI right? |
Yes, please! Then once the new image is built I need to change the tag on konflux-ci/release-service-catalog#719 |
|
/ok-to-test |
|
I don't know why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the regex patter for validating the staged directory path string.