From 67c7d44fc29c7589b681b599dd0731e717e3dc79 Mon Sep 17 00:00:00 2001 From: Adam Cmiel Date: Wed, 18 Sep 2024 15:56:03 +0200 Subject: [PATCH] rhtap: fix update-deployment condition The update-deployment task is supposed to run on push, but has been reported to run for MR comments as well. To fix this, rather than excluding the task for "pull_request" and "Merge Request" event types, run the task only for "push" and "Push" event types. --- Based on the pipelines-as-code codebase [1], mainly pkg/provider/*/parse_payload.go, the possible events and their corresponding event_type values are: | | anything except gitlab | gitlab |----------------|-----------------------------------|--------------- | PR | pull_request | Merge Request | PR comment | pull_request* | pull_request** | push | push | Push | tag push | push | Tag Push | commit comment | push (only github) | N/A | rerun button | pull_request / push (only github) | N/A * Depending on the Pipelines as Code version, PR comments may get categorized into many different event_types [2]. In version v0.27.2 (latest as of the date of this commit), they result in a pull_request event. See https://issues.redhat.com/browse/SRVKP-5775. ** In version v0.27.2, gitlab MR comments get the pull_request event_type due to the workaround for SRVKP-5775. Prior to version v0.25.0, they used to get the Note event_type. Between these versions, the would get one of the comment-specific event types [2]. --- TLDR: the user who noticed the task running for MR comments must have been using Pipelines as Code < v0.27.2, where the event_type would be {something}-comment (or Note, if < v0.25.0). Fix the condition to work for all PaC version. [1]: https://github.com/openshift-pipelines/pipelines-as-code [2]: https://pipelinesascode.com/docs/guide/gitops_commands/#event-type-annotation-and-dynamic-variables Signed-off-by: Adam Cmiel --- pipelines/docker-build-rhtap/patch.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pipelines/docker-build-rhtap/patch.yaml b/pipelines/docker-build-rhtap/patch.yaml index 02873fbfb3..f267ca268f 100644 --- a/pipelines/docker-build-rhtap/patch.yaml +++ b/pipelines/docker-build-rhtap/patch.yaml @@ -205,8 +205,10 @@ - update-deployment when: - input: "$(params.event-type)" - operator: notin - values: ["pull_request", "Merge Request"] + operator: in + values: + - "push" # all providers other than gitlab + - "Push" # gitlab taskRef: kind: Task name: acs-deploy-check