From 47cf4d53a6d856bc11211fffdf636c09cf01bf52 Mon Sep 17 00:00:00 2001 From: Julen Landa Alustiza Date: Thu, 21 Nov 2024 08:58:44 +0100 Subject: [PATCH] Make EC strict mode configurable Signed-off-by: Julen Landa Alustiza --- pipelines/enterprise-contract.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/pipelines/enterprise-contract.yaml b/pipelines/enterprise-contract.yaml index 30fbe77af2..580749151d 100644 --- a/pipelines/enterprise-contract.yaml +++ b/pipelines/enterprise-contract.yaml @@ -71,6 +71,15 @@ spec: type: string description: PipelineRun ID default: "pr/$(context.pipelineRun.name)" + - name: STRICT + type: string + description: | + A boolean flag that determines whether the result of the test will mark the TaskRun as passing or not. + Swap to false to make the IntegrationTestScenario informative. + + This is useful on specific conditions but will always mark the integration test as successful and + humans will tend ignore the test results if they failed. Use with caution. + default: "true" results: - name: TEST_OUTPUT value: "$(tasks.verify.results.TEST_OUTPUT)" @@ -83,12 +92,8 @@ spec: value: "$(params.SNAPSHOT)" - name: SSL_CERT_DIR value: "$(params.SSL_CERT_DIR)" - # It's confusing for users to see a passing taskrun that represents a failing EC test. - # For that reason let's have the taskrun fail when there are EC violations. Also, if - # this is set to false (IIUC), it's not possible to have the IntegrationTest gate the - # deploy to the devel environment work, which is what users expect to be able to do. - name: STRICT - value: "true" + value: "$(params.STRICT)" - name: PUBLIC_KEY value: "$(params.PUBLIC_KEY)" - name: IGNORE_REKOR