From a8c57897663b7631c2b5bb32d5c17d22eaa546f5 Mon Sep 17 00:00:00 2001
From: FelipeGuzmanSierra
 <97761783+FelipeGuzmanSierra@users.noreply.github.com>
Date: Mon, 5 Sep 2022 08:29:54 -0500
Subject: [PATCH] Add Signer 'new' method for keywordlist input (#219)

Co-authored-by: Jhonatan Hidalgo <108900469+jhonatan-kmt@users.noreply.github.com>

Co-authored-by: Jhonatan Hidalgo <108900469+jhonatan-kmt@users.noreply.github.com>
---
 lib/tx_build/signer.ex        |  2 ++
 test/tx_build/signer_test.exs | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/lib/tx_build/signer.ex b/lib/tx_build/signer.ex
index 714145d8..e0c8fb0e 100644
--- a/lib/tx_build/signer.ex
+++ b/lib/tx_build/signer.ex
@@ -16,6 +16,8 @@ defmodule Stellar.TxBuild.Signer do
   @impl true
   def new(args, opts \\ [])
 
+  def new([{_key_type, signer_key}, {:weight, weight}], _opts), do: new({signer_key, weight})
+
   def new({signer_key, weight}, _opts) do
     with {:ok, signer_key} <- validate_signer_key(signer_key),
          {:ok, weight} <- validate_signer_weight(weight) do
diff --git a/test/tx_build/signer_test.exs b/test/tx_build/signer_test.exs
index a60f39e9..0d3eed80 100644
--- a/test/tx_build/signer_test.exs
+++ b/test/tx_build/signer_test.exs
@@ -33,6 +33,14 @@ defmodule Stellar.TxBuild.SignerTest do
     %Signer{signer_key: ^signer_key, weight: ^weight} = Signer.new({ed25519, 2})
   end
 
+  test "new/2 ed25519 with_input_as_keywordlist", %{
+    ed25519: ed25519,
+    ed25519_signer_key: signer_key,
+    weight: weight
+  } do
+    %Signer{signer_key: ^signer_key, weight: ^weight} = Signer.new(ed25519: ed25519, weight: 2)
+  end
+
   test "new/2 sha256_hash", %{
     sha256_hash: sha256_hash,
     sha256_hash_signer_key: signer_key,
@@ -41,6 +49,15 @@ defmodule Stellar.TxBuild.SignerTest do
     %Signer{signer_key: ^signer_key, weight: ^weight} = Signer.new({sha256_hash, 2})
   end
 
+  test "new/2 sha256_hash with_input_as_keywordlist", %{
+    sha256_hash: sha256_hash,
+    sha256_hash_signer_key: signer_key,
+    weight: weight
+  } do
+    %Signer{signer_key: ^signer_key, weight: ^weight} =
+      Signer.new(sha256_hash: sha256_hash, weight: 2)
+  end
+
   test "new/2 pre_auth_tx", %{
     pre_auth_tx: pre_auth_tx,
     pre_auth_tx_signer_key: signer_key,
@@ -49,6 +66,15 @@ defmodule Stellar.TxBuild.SignerTest do
     %Signer{signer_key: ^signer_key, weight: ^weight} = Signer.new({pre_auth_tx, 2})
   end
 
+  test "new/2 pre_auth_tx with_input_as_keywordlist", %{
+    pre_auth_tx: pre_auth_tx,
+    pre_auth_tx_signer_key: signer_key,
+    weight: weight
+  } do
+    %Signer{signer_key: ^signer_key, weight: ^weight} =
+      Signer.new(pre_auth_tx: pre_auth_tx, weight: 2)
+  end
+
   test "new/2 signed_payload", %{
     signed_payload: signed_payload,
     signed_payload_signer_key: signer_key,
@@ -57,6 +83,15 @@ defmodule Stellar.TxBuild.SignerTest do
     %Signer{signer_key: ^signer_key, weight: ^weight} = Signer.new({signed_payload, 2})
   end
 
+  test "new/2 signed_payload with_input_as_keywordlist", %{
+    signed_payload: signed_payload,
+    signed_payload_signer_key: signer_key,
+    weight: weight
+  } do
+    %Signer{signer_key: ^signer_key, weight: ^weight} =
+      Signer.new(signed_payload: signed_payload, weight: 2)
+  end
+
   test "new/2 with_invalid_signer_key" do
     {:error, :invalid_signer_key} = Signer.new({"XCTP2Y5GZ7TTGHLM3JJKDIPR36", 2})
   end