Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs license #87

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Update docs license #87

merged 11 commits into from
Mar 13, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

@yasahi-hpc yasahi-hpc commented Mar 12, 2024

Resolves #86
Resolves #84

In this PR,

  1. Update the License to The Apache 2.0 License with LLVM Exception or the MIT License.
  2. Update the paths in README.md and docs
  3. Embed new licenses

@jbigot
Copy link
Member

jbigot commented Mar 12, 2024

We should offer both MIT & Apache-2 at the user's discretion

@jbigot
Copy link
Member

jbigot commented Mar 12, 2024

Also, we should follow reuse spec

@yasahi-hpc yasahi-hpc self-assigned this Mar 12, 2024
@yasahi-hpc
Copy link
Collaborator Author

@jbigot Modified accordingly

@jbigot
Copy link
Member

jbigot commented Mar 12, 2024

I have added reuse compliant licences, as well as a check, but now the line length check does not pass anymore, I must have a look at that.

@jbigot
Copy link
Member

jbigot commented Mar 12, 2024

Fixed, should be good now

@jbigot jbigot force-pushed the update-docs-license branch 3 times, most recently from a7d0853 to ed965ad Compare March 12, 2024 17:43
@yasahi-hpc
Copy link
Collaborator Author

@jbigot
Thanks!
I have two questions.

  1. Under LICENSES folder, we have BSD and CC0 licenses. Do we need them?
  2. It seems that .txt files are just templates. We do not need to embed our information?

@jbigot
Copy link
Member

jbigot commented Mar 13, 2024

We need BSD & CC0 because we have a few files that use them, namely FindFFTW for BSD & the reuse check for CC0, if we remove them the check will fail.

I don't believe we should embed any info in the licence files. The info is available from other places.

@yasahi-hpc
Copy link
Collaborator Author

Sure. Thank you for your explanation.
I will merge this and work on other issues

@yasahi-hpc yasahi-hpc merged commit e9753c2 into main Mar 13, 2024
23 checks passed
@yasahi-hpc yasahi-hpc deleted the update-docs-license branch March 13, 2024 08:58
@yasahi-hpc yasahi-hpc added the documentation Improvements or additions to documentation label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LICENCSE: Apache 2 LLVM exception nvcc version should be 11.0
2 participants