Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip comments #2

Open
mindplay-dk opened this issue May 19, 2017 · 1 comment
Open

Strip comments #2

mindplay-dk opened this issue May 19, 2017 · 1 comment

Comments

@mindplay-dk
Copy link
Collaborator

We ported this from JS, so the library only supports splitting SQL statements at this time.

Since this is PHP, we'll be using PDO, which doesn't play well with comments.

The library should therefore strip comments from SQL statements.

@mindplay-dk
Copy link
Collaborator Author

mindplay-dk commented May 22, 2017

On a related note, the library currently returns trailing comments (at the end of the file) as an individual query. (the original library does that - the tests didn't cover that case.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant