Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo doesn't work in multiple cases #70

Open
RareBreeds opened this issue Jul 3, 2022 · 4 comments
Open

Undo doesn't work in multiple cases #70

RareBreeds opened this issue Jul 3, 2022 · 4 comments

Comments

@RareBreeds
Copy link
Contributor

I was following this topic https://community.vcvrack.com/t/how-to-implement-undo-feature/17730 and tried out the Seq++ undo behavior and it doesn't seem to work correctly. I noticed a few issues in Seq++ and across other modules in the plugin.

  • Any module that has a drop down menu does not undo the drop down menu state
  • Whilst the Rec and Scroll buttons on Seq++ do undo, the Run button doesn't
  • Seq++ insert note does seem to register as a event that can be undone as the action is named in the edit menu, but if you undo it doesn't update the display.

I'm using a builds from source on macOS
plugin - d482868
Rack - v2.1.1

@squinkylabs
Copy link
Contributor

Do you really think "run" should be undoable? Is there any module where "run" is undoable?

@squinkylabs
Copy link
Contributor

btw, the dropdown does undo, but it doesn't readraw it's state after undo. I got a fix for that somewhere, @kockie69 is welcome to have it.

@squinkylabs
Copy link
Contributor

Interesting log entry:

error getting module in undo
error getting module in undo

@squinkylabs
Copy link
Contributor

I submitted some pull requests - one for the undo breaking in VCV 2.0, and the other to make the drop-downs undo correctly. So hopefully fixes will be coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants