Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support (and expose?) XLSForm 'hidden' controls #2239

Closed
tiritea opened this issue Mar 29, 2019 · 2 comments · Fixed by #2601
Closed

support (and expose?) XLSForm 'hidden' controls #2239

tiritea opened this issue Mar 29, 2019 · 2 comments · Fixed by #2601
Assignees
Labels
bug Things broken and not working as expected enhancement Ideas, improvements and features has PR UI & UX User interface problems and improvements

Comments

@tiritea
Copy link

tiritea commented Mar 29, 2019

Description

Kobo form builder presently does not recognize XLSForms with a 'hidden' data type present in an imported form (nor, obviously, does the KPI form builder support creating one).

bug (and candidate for enhancement if want to expose as new form builder widget)

Steps to Reproduce

  1. manually create an XLSForm with a 'hidden' data type row
  2. create-from-XLSForm a new form in Kobo
  3. edit form: will get "Row could not be displayed..." error
  4. export form

Expected behavior

even if KPI doesnt yet support a 'hidden' control widget, it could simply ignore the control in the form builder, but still re-export is as-is when creating a new XLSForm/XML.

Actual behavior

Instead, the original hidden control will be missing in new export

Additional details

'hidden' controls Kobo also referenced here: XLSForm/xlsform.github.io#116

See attached example:

hiddentest.xlsx

@magicznyleszek magicznyleszek self-assigned this Apr 29, 2019
@magicznyleszek magicznyleszek added bug Things broken and not working as expected enhancement Ideas, improvements and features UI & UX User interface problems and improvements labels Apr 29, 2019
@jnm jnm assigned duvld and unassigned magicznyleszek Mar 19, 2020
@jnm jnm added the has PR label Apr 9, 2020
@tinok
Copy link
Member

tinok commented Jun 22, 2020

@tiritea This feature is partially implemented with #2601. Do you have capacity to test this locally?

I'm wondering about the UI implementation. There is no point in defining a label for the hidden question. Should it be hidden? Our current UX flow requires either a label or a calculation to be specified before choosing the question type.

Is the default field the only useful field here? Maybe we could give users a hint for hidden questions that they can use that field in the settings to specify a constant.

If you have a specific use case that would be really helpful.

@tiritea tiritea closed this as completed Jun 22, 2020
@tiritea
Copy link
Author

tiritea commented Jun 22, 2020

sorry. hit wrong button - didnt mean to close it :-(

@tiritea tiritea reopened this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things broken and not working as expected enhancement Ideas, improvements and features has PR UI & UX User interface problems and improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants