Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Version 5.0.0 is missing some breaking changes on the CHANGELOG.md #227

Open
3 tasks done
marcossilvaxx opened this issue Feb 5, 2023 · 0 comments
Open
3 tasks done
Labels

Comments

@marcossilvaxx
Copy link

Version 5.0.0 is missing some breaking changes on the CHANGELOG.md

Node.js version: v16.19.0

OS version: Ubuntu 20.04.1

Description: Recently, after upgrading the package from version 4.2.0 to 6.0.1, I've found that some properties from the file object (when using the multipart parser) have been renamed. For example: the "path" property now is called "filepath", "name" is called "originalFilename", "type" is called "mimetype" and so on.

I believe this change happened in version 5.0.0, specifically in this PR: #201

It would be cool to include these breaking changes on CHANGELOG.md. :)

Actual behavior

CHANGELOG.md has no breaking changes regarding renaming file object properties in version 5.0.0.

Expected behavior

Add breaking changes regarding renaming file object properties in version 5.0.0.

Checklist

  • I have searched through GitHub issues for similar issues.
  • I have completely read through the README and documentation.
  • I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant