Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions for understanding the code #12

Open
janpio opened this issue Aug 3, 2018 · 2 comments
Open

Questions for understanding the code #12

janpio opened this issue Aug 3, 2018 · 2 comments

Comments

@janpio
Copy link
Contributor

janpio commented Aug 3, 2018

Looking at the code right now, trying to understand some things. I know this is quite old now, but maybe you still remember:

  1. ionic_ios_config_snapshot_action copies the test files for one scheme name (ui-snapshots by default). But then ionic_ios_snapshot_action loops over all schemes it finds. Why is that?

  2. Why is this output when it opens the project?

    UI.message("Xcode Project is Version #{proj.root_object.compatibility_version} Compatible")

  3. Why is ionic_min_target_os a parameter? Where and why would one need this?

  4. Why the configurable scheme name? Is there any use to be able to give this a specific name that I don't see (yet)?

@janpio
Copy link
Contributor Author

janpio commented Aug 4, 2018

  1. Why the separation into two actions?

@janpio
Copy link
Contributor Author

janpio commented Aug 6, 2018

'1) and 4) are probably to enable adding of multiple "test suites". The first action just creates new files under a specified "scheme name", the other then works with all schemes it can find to integrate them into the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant