-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to override jwks_url #8376
base: main
Are you sure you want to change the base?
Conversation
Welcome @KapilSareen! It looks like this is your first PR to knative/eventing 🎉 |
Hi @KapilSareen. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KapilSareen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @creydr |
We should probably have at least an |
Fixes #8348
Proposed Changes
jwks-uri
configurable, allowing the default value to be overwritten by passing a value inJWKSURI
in the feature config.""
), and use the JWKS URI provided byoidc-discovery-base-url
if nojwks-uri
is specified.Pre-review Checklist