Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override jwks_url #8376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KapilSareen
Copy link

@KapilSareen KapilSareen commented Dec 8, 2024

Fixes #8348

Proposed Changes

  • Make jwks-uri configurable, allowing the default value to be overwritten by passing a value in JWKSURI in the feature config.
  • Default to an empty string (""), and use the JWKS URI provided by oidc-discovery-base-url if no jwks-uri is specified.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo December 8, 2024 21:00
@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 8, 2024
Copy link

knative-prow bot commented Dec 8, 2024

Welcome @KapilSareen! It looks like this is your first PR to knative/eventing 🎉

Copy link

knative-prow bot commented Dec 8, 2024

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 8, 2024
Copy link

knative-prow bot commented Dec 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KapilSareen
Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/cc @creydr

@knative-prow knative-prow bot requested a review from creydr December 13, 2024 08:01
@maschmid
Copy link
Contributor

We should probably have at least an oidc- prefix, so, maybe oidc-jwks-uri ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to override jwks_url
3 participants