Not filter properly calls cleanup on it's nested filter #7310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <[email protected]>
knative-prow
bot
added
the
size/XS
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7310 +/- ##
==========================================
- Coverage 77.66% 77.63% -0.03%
==========================================
Files 250 250
Lines 13436 13437 +1
==========================================
- Hits 10435 10432 -3
- Misses 2478 2481 +3
- Partials 523 524 +1
☔ View full report in Codecov by Sentry. |
|
/lgtm |
knative-prow
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test upgrade-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where the not filter does not call Cleanup on the nested filter. For the Any filter and All filter dialects, this cleanup method is needed to cleanup goroutines which are created, so without this the Not filter would create a memory leak.