Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Update Deprecated generate-groups.sh to kube_codegen.sh #636

Open
inspirit941 opened this issue Oct 15, 2024 · 0 comments · May be fixed by #641
Open

Proposal: Update Deprecated generate-groups.sh to kube_codegen.sh #636

inspirit941 opened this issue Oct 15, 2024 · 0 comments · May be fixed by #641

Comments

@inspirit941
Copy link

inspirit941 commented Oct 15, 2024 •
edited
Loading

I've noticed that the generate-groups.sh script currently used in hack/update-codegen.sh is deprecated and no longer functioning. (https://github.com/kubernetes/code-generator/blob/master/generate-groups.sh)

I'd like to propose updating it to kube_codegen.sh to address this issue.

Proposal

  • Replace generate-groups.sh with kube_codegen.sh.

I've personally tested this change by modifying the update-codegen script to use kube_codegen.sh, and it works as expected.

Questions

  • Would it be appropriate to submit a Pull Request with these changes?
  • Are there any additional considerations I should be aware of before proceeding?
@inspirit941 inspirit941 linked a pull request Oct 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: migrate to kube_codegen inspirit941/sample-source
1 participant
@inspirit941