Skip to content

Commit

Permalink
require manual minikube tunnel on linux too (#302)
Browse files Browse the repository at this point in the history
Signed-off-by: Paul S. Schweigert <[email protected]>

Co-authored-by: Paul S. Schweigert <[email protected]>
  • Loading branch information
knative-prow-robot and psschwei authored Jun 10, 2022
1 parent a30fe81 commit e9a3897
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 21 deletions.
12 changes: 0 additions & 12 deletions pkg/install/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package install
import (
"fmt"
"os/exec"
"runtime"
"strings"
"time"
)
Expand Down Expand Up @@ -104,17 +103,6 @@ func KourierMinikube() error {

fmt.Println(" Domain DNS set up...")

// For windows and mac users, do not automatically spawn a tunnel
// Instead, they will be directed to create one manually after
// the plugin finishes
if runtime.GOOS != "window" && runtime.GOOS != "darwin" {
tunnel := exec.Command("minikube", "tunnel", "--profile", "knative")
if err := tunnel.Start(); err != nil {
return fmt.Errorf("tunnel: %w", err)
}
fmt.Println(" Minikube tunnel...")
}

fmt.Println(" Finished configuring Kourier")
return nil
}
Expand Down
15 changes: 6 additions & 9 deletions pkg/minikube/minikube.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"os"
"os/exec"
"regexp"
"runtime"
"strconv"
"strings"
"time"
Expand Down Expand Up @@ -61,14 +60,12 @@ func SetUp(name, kVersion string, installServing, installEventing bool) error {
if err := createMinikubeCluster(); err != nil {
return fmt.Errorf("creating cluster: %w", err)
}
if runtime.GOOS == "darwin" || runtime.GOOS == "windows" {
fmt.Print("\n")
fmt.Println("To finish setting up networking for minikube, run the following command in a separate terminal window:")
fmt.Println(" minikube tunnel --profile knative")
fmt.Println("The tunnel command must be running in a terminal window any time when using the knative quickstart environment.")
fmt.Println("\nPress the Enter key to continue")
fmt.Scanln()
}
fmt.Print("\n")
fmt.Println("To finish setting up networking for minikube, run the following command in a separate terminal window:")
fmt.Println(" minikube tunnel --profile knative")
fmt.Println("The tunnel command must be running in a terminal window any time when using the knative quickstart environment.")
fmt.Println("\nPress the Enter key to continue")
fmt.Scanln()

if installServing {
if err := install.Serving(); err != nil {
Expand Down

0 comments on commit e9a3897

Please sign in to comment.