Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket error occurs when restarting Redis #387

Open
tdeverdiere opened this issue Oct 4, 2022 · 13 comments · May be fixed by #628
Open

Socket error occurs when restarting Redis #387

tdeverdiere opened this issue Oct 4, 2022 · 13 comments · May be fixed by #628
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@tdeverdiere
Copy link
Contributor

Describe the bug
In k8s cluster, when Redis is restarted eventing-redis use an old socket to connect and there is this error in logs:

{"severity":"ERROR","timestamp":"2022-10-03T14:04:38.422117731Z","logger":"redis-stream-source","caller":"adapter/adapter.go:185","message":"Cannot read from stream","commit":"6becb00-dirty","stream":"vms:changes","error":"write tcp 10.6.4.171:58374->172.20.208.153:6379: use of closed network connection","stacktrace":"knative.dev/eventing-redis/source/pkg/adapter.(*Adapter).processEntry\n\tknative.dev/eventing-redis/source/pkg/adapter/adapter.go:185\nknative.dev/eventing-redis/source/pkg/adapter.(*Adapter).Start.func1\n\tknative.dev/eventing-redis/source/pkg/adapter/adapter.go:156"}

Expected behavior
Eventing-redis should reopen a socket when the error is "use of closed network connection".
Or may be we should use a pool of connection to handle those error.

To Reproduce
Restart Redis in the k8s cluster
@tdeverdiere tdeverdiere added the kind/bug Categorizes issue or PR as related to a bug. label Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2023
@github-actions github-actions bot closed this as completed Feb 2, 2023
@christophefromparis
Copy link

/reopen

@knative-prow
Copy link

knative-prow bot commented Mar 13, 2023

@christophefromparis: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aavarghese
Copy link
Contributor

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2023
@aavarghese aavarghese reopened this Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@pierDipi
Copy link
Member

pierDipi commented Jul 3, 2023

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2023
@github-actions github-actions bot closed this as completed Nov 1, 2023
@tdeverdiere
Copy link
Contributor Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023
@tdeverdiere
Copy link
Contributor Author

/reopen

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 3, 2023

@tdeverdiere: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot reopened this Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2024
@github-actions github-actions bot closed this as completed Mar 3, 2024
@tdeverdiere tdeverdiere mentioned this issue Oct 1, 2024
Open
@tdeverdiere
Copy link
Contributor Author

/reopen

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 11, 2024

@tdeverdiere: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot reopened this Oct 11, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2024
tdeverdiere added a commit to tdeverdiere/eventing-redis that referenced this issue Oct 15, 2024
@tdeverdiere
Simple fix for knative-extensions#387: return a panic error
fe60ec9
@tdeverdiere tdeverdiere mentioned this issue Oct 15, 2024
Closed
tdeverdiere added a commit to tdeverdiere/eventing-redis that referenced this issue Oct 21, 2024
@tdeverdiere
Fix knative-extensions#387 Panic if Redis client returns use of close…
8eb7743 
…d network connection
@tdeverdiere tdeverdiere linked a pull request Oct 21, 2024 that will close this issue
Open
tdeverdiere added a commit to tdeverdiere/eventing-redis that referenced this issue Oct 21, 2024
@tdeverdiere
Fix knative-extensions#387 Panic if Redis client returns use of close…
09b7a34 
…d network connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
4 participants
@aavarghese @tdeverdiere @christophefromparis @pierDipi