Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: feat: triggerv2 supports cross namespace references #4060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP]: feat: triggerv2 supports cross namespace references #4060

wants to merge 1 commit into from

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Aug 13, 2024 •
edited by pierDipi
Loading

E2E tests will be added once knative/eventing#8157 merges

Fixes #4080

TODO:

  • Channel
  • E2E tests (broker-based from core)
  • Unit tests

Proposed Changes

Release Note

Docs

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member Author

/cc @Leo6Leo @creydr

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.45%. Comparing base (073bcd2) to head (a1bb7a8).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go 22.22% 7 Missing ⚠️
...ntrol-plane/pkg/reconciler/trigger/v2/triggerv2.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4060      +/-   ##
==========================================
+ Coverage   48.41%   48.45%   +0.03%     
==========================================
  Files         244      244              
  Lines       14514    14554      +40     
==========================================
+ Hits         7027     7052      +25     
- Misses       6777     6790      +13     
- Partials      710      712       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member Author

/assign @pierDipi

@pierDipi
Copy link
Member

/retest

@Cali0707
Copy link
Member Author

/test upgrade-tests
/cc @pierDipi any feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok Awaiting requested review from aliok

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@creydr creydr Awaiting requested review from creydr

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger BrokerRef and Cross namespace references
2 participants
@Cali0707 @pierDipi