Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies #55

Open
KarelWintersky opened this issue May 29, 2024 · 3 comments

Comments

@KarelWintersky
Copy link

Gulp Copy uses chokidar 2, please update

@klaascuvelier
Copy link
Owner

Hi @KarelWintersky thanks for reporting this. I was not really planning on doing anymore updates to this package.
Can you maybe share a bit of your gulp setup to see if there's an option just not to use this package anymore?

@KarelWintersky
Copy link
Author

smth like

gulp.task('images', function () {
    return gulp
        .src(configuration.paths.images.src)
        .pipe(copy(configuration.paths.images.dest, {
            prefix: 1
        }))
        ;
});

why not only

gulp.task('images', function () {
    return gulp
        .src(configuration.paths.images.src, { encoding: false })
        .pipe(gulp.dest(configuration.paths.images.dest))
        ;
});

A problem:

In new gulp encoding: false is REQUIRED. Because this setting in the latest version of Gulp is strictly necessary - but why and why - it turned out quite by accident, after a long thoughtful search for an error (why, after copying an image using standard tools, it is not shown and has become one and a half times larger, and why does this only apply to binary files?)

But if you don't plan to support the project anymore, I think there will be nothing wrong if I fork it, fix what I need and release a new version on the NPMJS package repository and download the necessary package for myself.

@klaascuvelier
Copy link
Owner

I just bumped dependencies and added support for Gulp 5 through PR #56
This should also have bumped chokidar and resolved your issues I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants