-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use aria2c 1.37.0 in Kiwix-Desktop Appimage #783
Comments
Actually it seems we already use latest version... but I feel lost as it seemed the release has been made a few weeks ago. Anyway, closing. |
Appimage creation script uses aria2 v1.36: kiwix-build/scripts/create_kiwix-desktop_appImage.sh Lines 32 to 33 in 0109c8c
|
Ok... reopening and I will try to amke a patch to fix ASAP. |
@veloman-yunkan I had again a look in detail. It seems indeed that we use the proper/latest version of aria2c everywhere except the appimage. Beside the fact that this is "hidden" in another file than the usual dedicated Python module, I have remarked that the 1.37.0 release on GitHub does not provide such a binary for Linux. Beside the fact that we need to compile aria2c statically for LInux (to then include it in the Does that sound good? |
So, original source of binaries has not a binary of aria2c 1.37.0 https://github.com/q3aql/aria2-static-builds/ But I have found an alternative at https://github.com/abcfy2/aria2-static-build/releases/tag/1.37.0, without properly fixing the problem this might help at least to move forward. |
I believe that there is still some confusion here as aria2 1.37 has been released more than a year ago. |
Yes, the only confusion is that I shortly believed it has been newly release this year. But the only problem is the appimage. All the rest looks good (beside the fact that we use binaries and don't compile them ourself). |
See aria2/aria2#2136
because of kiwix/kiwix-desktop#809
The text was updated successfully, but these errors were encountered: