Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aria2c 1.37.0 in Kiwix-Desktop Appimage #783

Closed
kelson42 opened this issue Dec 9, 2024 · 7 comments · Fixed by #790
Closed

Use aria2c 1.37.0 in Kiwix-Desktop Appimage #783

kelson42 opened this issue Dec 9, 2024 · 7 comments · Fixed by #790
Assignees

Comments

@kelson42
Copy link
Contributor

kelson42 commented Dec 9, 2024

See aria2/aria2#2136
because of kiwix/kiwix-desktop#809

@kelson42
Copy link
Contributor Author

Actually it seems we already use latest version... but I feel lost as it seemed the release has been made a few weeks ago. Anyway, closing.

@veloman-yunkan
Copy link
Collaborator

Actually it seems we already use latest version...

Appimage creation script uses aria2 v1.36:

# get the aria2
wget --continue https://github.com/q3aql/aria2-static-builds/releases/download/v1.36.0/aria2-1.36.0-linux-gnu-64bit-build1.tar.bz2

@kelson42 kelson42 reopened this Dec 18, 2024
@kelson42
Copy link
Contributor Author

Ok... reopening and I will try to amke a patch to fix ASAP.

@kelson42 kelson42 changed the title User aria2c 1.37.0 Use aria2c 1.37.0 in Appimage Dec 18, 2024
@kelson42 kelson42 changed the title Use aria2c 1.37.0 in Appimage Use aria2c 1.37.0 in Kiwix-Desktop Appimage Dec 18, 2024
@kelson42
Copy link
Contributor Author

@veloman-yunkan I had again a look in detail. It seems indeed that we use the proper/latest version of aria2c everywhere except the appimage.

Beside the fact that this is "hidden" in another file than the usual dedicated Python module, I have remarked that the 1.37.0 release on GitHub does not provide such a binary for Linux.

Beside the fact that we need to compile aria2c statically for LInux (to then include it in the .appimage), I would like that this is handled properly in aria2.py. Then this would be part of the dependencies files... which could then be downloaded to create properly the appimage.

Does that sound good?

@kelson42
Copy link
Contributor Author

kelson42 commented Dec 18, 2024

So, original source of binaries has not a binary of aria2c 1.37.0 https://github.com/q3aql/aria2-static-builds/

But I have found an alternative at https://github.com/abcfy2/aria2-static-build/releases/tag/1.37.0, without properly fixing the problem this might help at least to move forward.

@veloman-yunkan
Copy link
Collaborator

but I feel lost as it seemed the release has been made a few weeks ago.

I believe that there is still some confusion here as aria2 1.37 has been released more than a year ago.

@kelson42
Copy link
Contributor Author

but I feel lost as it seemed the release has been made a few weeks ago.

I believe that there is still some confusion here as aria2 1.37 has been released more than a year ago.

Yes, the only confusion is that I shortly believed it has been newly release this year. But the only problem is the appimage. All the rest looks good (beside the fact that we use binaries and don't compile them ourself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants