Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLL and dependency libs are not published #743

Closed
kelson42 opened this issue Aug 30, 2024 · 2 comments · Fixed by #745
Closed

DLL and dependency libs are not published #743

kelson42 opened this issue Aug 30, 2024 · 2 comments · Fixed by #745
Assignees
Labels

Comments

@kelson42
Copy link
Contributor

See https://download.kiwix.org/nightly/2024-08-30/libkiwix_win-i686-2024-08-30.zip, I see only the headers

@mgautierfr
Copy link
Member

This is not a regression (See https://download.kiwix.org/release/libkiwix/libkiwix_win-i686-12.1.0.zip)

I think this archive is wrongly published.
First of all, it is not publish on release.
Nightly is uploading everything it build (even if not set to be published) and I think we should not.

On top of that, this library is created from static build (which obviously doesn't contain dll)
And it is from cross-compilation from f35, which will be removed.
We would better fix native dynamic compilation on libkiwix and correctly publish it (if we need to publish it as no ask for it until now)

@kelson42
Copy link
Contributor Author

kelson42 commented Aug 30, 2024

Not a regression indeed. AFAIK we have no usage for these windows binaries. Therefore, either it is published and OK (so with dll) or we stop publishing the whole tarball.

The whole windows cross compulation should be removed anyway. This is important to remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants