Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current version is broken #723

Closed
TimoGo opened this issue Aug 20, 2024 · 0 comments · Fixed by #724
Closed

current version is broken #723

TimoGo opened this issue Aug 20, 2024 · 0 comments · Fixed by #724
Assignees

Comments

@TimoGo
Copy link

TimoGo commented Aug 20, 2024

version 2a9d545 from 20th August is broken, compiling ends up with:

  download icu4c : OK (8.3s)
  extract icu4c : ERROR
Traceback (most recent call last):
  File "/root/bin/kiwix-build", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/root/lib/python3.11/site-packages/kiwixbuild/__init__.py", line 166, in main
    builder.run()
  File "/root/lib/python3.11/site-packages/kiwixbuild/builder.py", line 201, in run
    self.prepare_sources()
  File "/root/lib/python3.11/site-packages/kiwixbuild/builder.py", line 111, in prepare_sources
    source.prepare()
  File "/root/lib/python3.11/site-packages/kiwixbuild/dependencies/base.py", line 160, in prepare
    self.command("extract", self._extract)
  File "/root/lib/python3.11/site-packages/kiwixbuild/dependencies/base.py", line 94, in command
    ret = function(*args, context=context)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/lib/python3.11/site-packages/kiwixbuild/dependencies/icu4c.py", line 142, in _extract
    pj(neutralEnv("archive_dir"), self.meson_patch.name),
                                  ^^^^^^^^^^^^^^^^
AttributeError: 'Source' object has no attribute 'meson_patch'
(root) root@9aef25fe1532:~/kiwix-build# 

For reproduction:

docker run -ti --rm  --name kiwixbuild debian:12.4

apt update && apt -y upgrade && apt -y install build-essential git && apt -y install meson ninja-build cmake sudo && apt -y install python3-pip virtualenv
cd
virtualenv -p python3 ./
source bin/activate
  
git clone https://github.com/kiwix/kiwix-build
cd kiwix-build/
pip3 install .
hash -r
kiwix-build zim-tools

When I use yesterdays version (ad72464), everything is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants