Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing of special characters / URL encoded links is not working as expected #3755

Closed
benoit74 opened this issue Mar 18, 2024 · 5 comments · Fixed by #3768
Closed

Processing of special characters / URL encoded links is not working as expected #3755

benoit74 opened this issue Mar 18, 2024 · 5 comments · Fixed by #3768
Assignees
Labels
Milestone

Comments

@benoit74
Copy link

Description

See openzim/libzim#865 (comment) for details. We should probably wait for discussion to settle in this issue before developing some on Android, but we most probably have to fix something on Android.

We have a test ZIM at https://tmp.kiwix.org/ci/zim_characters_encoding/characters_encoding.zim with many situations in terms of URL encoding inside an HTML document and corresponding ZIM entry path.

Current Android reader behavior is not aligned with kiwix-serve behavior and will probably have to aligned (again, once discussion on openzim/libzim#865 has settled) :

  • many links are not working while they should (at least they work in kiwix-serve)
  • some links are working but not leading to the proper ZIM entry (at least the one which is served by kiwix-serve on web browser desktop)

Environment

  • Version of Kiwix Android : 2024-03-17 nightly
  • Device : Fairphone 4
  • OS version : 13
@kelson42
Copy link
Collaborator

@MohitMaliFtechiz Very serious bug/topic, please look in priority. I can only insist again than URL parsing should be solid and well tested.

@MohitMaliFtechiz
Copy link
Collaborator

@benoit74 Thanks for providing the ZIM file, we have refactored our code to support the URLs in our application at #3768. Now it is working like kiwix-server.

@benoit74
Copy link
Author

Great ! I just had a look at the video in PR and confirm the new behavior is exactly as expected. Glad a great test case / ZIM helped to solve this complex topic so fast!

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Mar 27, 2024

@benoit74 Thanks for giving your valuable feedback.

@kelson42 kelson42 modified the milestones: 3.11.0, 3.10.0 Mar 29, 2024
@benoit74
Copy link
Author

benoit74 commented Apr 5, 2024

I've installed last nightly and can confirm it works as expected from my PoV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants