diff --git a/.eslintrc.cjs b/.eslintrc.cjs index 8b5dbe11d4..787bc9bf5f 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -5,7 +5,6 @@ const CONFIGS = [ "plugin:react-hooks/recommended", "plugin:prettier/recommended", "plugin:tailwindcss/recommended", - "plugin:orbit-components/internal", ]; module.exports = { diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index bf54d7bfaf..0efeda7aed 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -42,7 +42,6 @@ jobs: yarn tokens build yarn tailwind-preset build yarn components build - yarn workspace @kiwicom/eslint-plugin-orbit-components build - name: Dry run if: ${{ github.event.inputs.dryrun == 'true' }} diff --git a/docs/.eslintrc.cjs b/docs/.eslintrc.cjs index f7270800eb..8ac18d265c 100644 --- a/docs/.eslintrc.cjs +++ b/docs/.eslintrc.cjs @@ -99,7 +99,6 @@ module.exports = { files: "**/__examples__/**/*.*", rules: { "import/no-useless-path-segments": ["error", { noUselessIndex: false }], - "orbit-components/unique-id": "off", "react/no-unstable-nested-components": "off", }, }, diff --git a/docs/package.json b/docs/package.json index 47390c6f7c..1a931da930 100644 --- a/docs/package.json +++ b/docs/package.json @@ -30,7 +30,6 @@ "@icons-pack/react-simple-icons": "^8.0.1", "@jsdevtools/rehype-url-inspector": "^2.0.2", "@kiwicom/babel-plugin-orbit-components": "*", - "@kiwicom/eslint-plugin-orbit-components": "*", "@kiwicom/orbit-components": "*", "@kiwicom/orbit-design-tokens": "*", "@kiwicom/orbit-tailwind-preset": "*", diff --git a/docs/src/documentation/05-development/01-guides/03-eslint-plugin.mdx b/docs/src/documentation/05-development/01-guides/03-eslint-plugin.mdx deleted file mode 100644 index 7267768ff5..0000000000 --- a/docs/src/documentation/05-development/01-guides/03-eslint-plugin.mdx +++ /dev/null @@ -1,10 +0,0 @@ ---- -title: ESLint plugin -description: How to install and use the ESLint plugin for Orbit components. -redirect_from: - - /guides/eslint-plugin/ ---- - -import ESLintPluginReadMe from "@kiwicom/eslint-plugin-orbit-components/README.md"; - - diff --git a/docs/src/pages/mdx-examples.mdx b/docs/src/pages/mdx-examples.mdx index 57c986aacf..727245dbb5 100644 --- a/docs/src/pages/mdx-examples.mdx +++ b/docs/src/pages/mdx-examples.mdx @@ -153,22 +153,20 @@ It should only present information that could end up destroying previous progres ## Tables -| Package | Description | -| ------------------------------ | ---------------------------------------------------------- | -| orbit-components | All our React components along with API documentation. | -| orbit-design-tokens | All visual UI attributes available as tokens. | -| eslint-plugin-orbit-components | ESLint rules to enforce best practices for our components. | +| Package | Description | +| ------------------- | ------------------------------------------------------ | +| orbit-components | All our React components along with API documentation. | +| orbit-design-tokens | All visual UI attributes available as tokens. | ### Aligned columns In addition to the default of left alignment, columns can also be right or center aligned. Set alignment with colons in the header row. -| Option | Description | -| -----------------------------: | :--------------------------------------------------------: | -| orbit-components | All our React components along with API documentation. | -| orbit-design-tokens | All visual UI attributes available as tokens. | -| eslint-plugin-orbit-components | ESLint rules to enforce best practices for our components. | +| Option | Description | +| ------------------: | :----------------------------------------------------: | +| orbit-components | All our React components along with API documentation. | +| orbit-design-tokens | All visual UI attributes available as tokens. | ## Links diff --git a/package.json b/package.json index 906e9d0f0c..6b2de80a28 100644 --- a/package.json +++ b/package.json @@ -95,7 +95,6 @@ "eslint-plugin-import": "^2.27.5", "eslint-plugin-jest": "^27.2.1", "eslint-plugin-jsx-a11y": "^6.10.0", - "eslint-plugin-orbit-components": "*", "eslint-plugin-prettier": "^4.2.1", "eslint-plugin-react": "^7.33.2", "eslint-plugin-react-hooks": "^4.2.0", diff --git a/packages/orbit-components/.eslintrc.cjs b/packages/orbit-components/.eslintrc.cjs index 5b75760f1f..3364baca31 100644 --- a/packages/orbit-components/.eslintrc.cjs +++ b/packages/orbit-components/.eslintrc.cjs @@ -37,7 +37,6 @@ module.exports = { { files: "*.stories.*", rules: { - "orbit-components/unique-id": "off", "react/no-unstable-nested-components": "off", // TODO: remove after migration to a new actions "import/no-extraneous-dependencies": "off", @@ -59,7 +58,6 @@ module.exports = { { files: ["src/**/*.test.ts?(x)", "src/test-utils.tsx"], rules: { - "orbit-components/unique-id": "off", "import/no-extraneous-dependencies": [ "error", { diff --git a/packages/orbit-components/src/Accordion/Accordion.ct-story.tsx b/packages/orbit-components/src/Accordion/Accordion.ct-story.tsx index b4cde76937..76709dc39b 100644 --- a/packages/orbit-components/src/Accordion/Accordion.ct-story.tsx +++ b/packages/orbit-components/src/Accordion/Accordion.ct-story.tsx @@ -5,8 +5,6 @@ import Text from "../Text"; import Accordion, { AccordionSection } from "."; -/* eslint-disable orbit-components/unique-id */ - export default function AccordionVisualTest() { return (
diff --git a/packages/orbit-components/src/Layout/Layout.ct-story.tsx b/packages/orbit-components/src/Layout/Layout.ct-story.tsx index eb511668d2..8d303557f5 100644 --- a/packages/orbit-components/src/Layout/Layout.ct-story.tsx +++ b/packages/orbit-components/src/Layout/Layout.ct-story.tsx @@ -54,7 +54,6 @@ export function LayoutStoryWizard() { - {/* eslint-disable-next-line orbit-components/unique-id */} diff --git a/packages/orbit-components/src/OrbitProvider/index.tsx b/packages/orbit-components/src/OrbitProvider/index.tsx index 64b566f65f..8364c27ec5 100644 --- a/packages/orbit-components/src/OrbitProvider/index.tsx +++ b/packages/orbit-components/src/OrbitProvider/index.tsx @@ -47,7 +47,6 @@ const getCssVarsForWL = (theme: typeof defaultTokens) => const OrbitProvider = ({ theme, children, useId }: Props) => { return ( - {/* eslint-disable-next-line orbit-components/unique-id */} diff --git a/packages/orbit-components/src/Popover/index.tsx b/packages/orbit-components/src/Popover/index.tsx index c218709bce..c03c844496 100644 --- a/packages/orbit-components/src/Popover/index.tsx +++ b/packages/orbit-components/src/Popover/index.tsx @@ -166,7 +166,6 @@ const Popover = ({ {children}
{render && - // eslint-disable-next-line orbit-components/unique-id (renderInPortal ? {popover} : popover)} ); diff --git a/packages/orbit-components/src/primitives/TooltipPrimitive/index.tsx b/packages/orbit-components/src/primitives/TooltipPrimitive/index.tsx index 74e541d001..cdceffd3a7 100644 --- a/packages/orbit-components/src/primitives/TooltipPrimitive/index.tsx +++ b/packages/orbit-components/src/primitives/TooltipPrimitive/index.tsx @@ -138,7 +138,6 @@ const TooltipPrimitive = ({ {enabled && render && - // eslint-disable-next-line orbit-components/unique-id (renderInPortal ? {tooltip} : tooltip)} ); diff --git a/tsconfig.json b/tsconfig.json index 49e0323118..de88b866bf 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,8 +6,7 @@ "include": [ "packages/orbit-components/**/*", "packages/orbit-design-tokens/**/*", - "packages/orbit-themer/**/*", - "packages/eslint-plugin-orbit-components/**/*" + "packages/orbit-themer/**/*" ], "exclude": [ "**/scripts/**/*", diff --git a/utils/eslint.js b/utils/eslint.js index ccc1899961..bb294b5d4f 100644 --- a/utils/eslint.js +++ b/utils/eslint.js @@ -16,7 +16,6 @@ exports.DEV_DEPENDENCIES = [ "**/tasks/**", "docs/**", "packages/*/.storybook/**", - "packages/eslint-plugin-orbit-components/**", "packages/orbit-design-tokens/src/theo/**", "packages/orbit-components/cypress.config.ts", "packages/orbit-components/playwright-ct.config.ts", diff --git a/yarn.lock b/yarn.lock index d2d97b8433..ca1cb727bc 100644 --- a/yarn.lock +++ b/yarn.lock @@ -538,7 +538,7 @@ resolved "https://registry.yarnpkg.com/@babel/helper-string-parser/-/helper-string-parser-7.24.8.tgz#5b3329c9a58803d5df425e5785865881a81ca48d" integrity sha512-pO9KhhRcuUyGnJWwyEgnRJTSIZHiT+vMD0kPeD+so0l7mxkMT19g3pjY9GTnHySck/hDzq+dtW/4VgnMkippsQ== -"@babel/helper-validator-identifier@^7.10.4", "@babel/helper-validator-identifier@^7.22.5", "@babel/helper-validator-identifier@^7.24.5": +"@babel/helper-validator-identifier@^7.22.5", "@babel/helper-validator-identifier@^7.24.5": version "7.24.5" resolved "https://registry.yarnpkg.com/@babel/helper-validator-identifier/-/helper-validator-identifier-7.24.5.tgz#918b1a7fa23056603506370089bd990d8720db62" integrity sha512-3q93SSKX2TWCG30M2G2kwaKeTYgEUp5Snjuj8qm729SObL6nbtUldAi37qbxkD5gg3xnBio+f9nqpSepGZMvxA== @@ -2146,15 +2146,6 @@ debug "^4.3.1" globals "^11.1.0" -"@babel/types@=7.12.10": - version "7.12.10" - resolved "https://registry.npmjs.org/@babel/types/-/types-7.12.10.tgz" - integrity sha512-sf6wboJV5mGyip2hIpDSKsr80RszPinEFjsHTalMxZAZkoQ2/2yQzxlcFN52SJqsyPfLtPmenL4g2KB3KJXPDw== - dependencies: - "@babel/helper-validator-identifier" "^7.10.4" - lodash "^4.17.19" - to-fast-properties "^2.0.0" - "@babel/types@^7.0.0", "@babel/types@^7.0.0-beta.49", "@babel/types@^7.12.7", "@babel/types@^7.15.4", "@babel/types@^7.16.7", "@babel/types@^7.16.8", "@babel/types@^7.20.0", "@babel/types@^7.20.7", "@babel/types@^7.21.4", "@babel/types@^7.22.5", "@babel/types@^7.23.0", "@babel/types@^7.24.0", "@babel/types@^7.24.5", "@babel/types@^7.3.3", "@babel/types@^7.4.4": version "7.24.5" resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.24.5.tgz#7661930afc638a5383eb0c4aee59b74f38db84d7" @@ -11803,13 +11794,6 @@ eslint-plugin-mdx@^1.17.0: tslib "^2.3.1" vfile "^4.2.1" -eslint-plugin-orbit-components@*: - version "0.6.10" - resolved "https://registry.npmjs.org/eslint-plugin-orbit-components/-/eslint-plugin-orbit-components-0.6.10.tgz" - integrity sha512-14wKnl/awCZZaFHv3sq3IPmF/9Zhc0M/myoQRIa+7ysRWeZP1frtIaI8U+nUbsXLa0MGU8vJrfV4Z5hDgVrpuA== - dependencies: - "@babel/types" "=7.12.10" - eslint-plugin-prettier@^4.2.1: version "4.2.1" resolved "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz"