Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for android.debug_artifact should be dependent on p4a.bootstrap value. #1655

Open
Julian-O opened this issue Aug 4, 2023 · 1 comment

Comments

@Julian-O
Copy link
Contributor

Julian-O commented Aug 4, 2023

Description

  • The default value for android.debug_artifact is (always) apk. However, when p4a.bootstrap is service_library, you aren't building an apk, you are building an aar, and the default should change with it. (Failing to override leads to a build failure, as the binary isn't found.

  • I think android.release_artifact should change from aab to aar as well, but I am out of my depth here, and would appreciate a second opinion to confirm.

What makes this messy is the default is set in target.py when it logically should be set in android.py, so the first step is to properly separate the concerns of Android builds from the generic target.

@misl6
Copy link
Member

misl6 commented Aug 6, 2023

Hi @Julian-O,

I agree on both. When p4a.bootstrap is service_library, we should default to aar for both debug and release artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants