feat: support ttl check and update ttl #17
Conversation
nnothing1
commented
Dec 2, 2024
nnothing1
commented
- Support TTL check and auto update TTL after registering to Consul
- Add unit test
- fix Can not use TTL checks #16
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nnothing1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@baiyutang 麻烦看看 |
| return c.consulClient.Agent().ServiceDeregister(svcID) | ||
| } | ||
|
|
||
| // startTTLHeartbeat start a goroutine to periodically update TTL. | ||
| func (c *consulRegistry) startTTLHeartbeat(ttl time.Duration) error { | ||
| if ttl <= 1*time.Second { |
There was a problem hiding this comment.
这个参数校验可以放在更前边，放在注册之前去校验 Agent().ServiceRegister(svcInfo);
| // wait for health check passing | ||
| time.Sleep(time.Second * 6) | ||
|
|
||
| list, _, err := consulClient.Health().Service(testSvcName, "", true, nil) |
There was a problem hiding this comment.
这里去获取服务实例列表，建议多等待几个 TTL 的周期，或者连续去校验几个 TTL 周期，证明更新是有效的。
| ctx, cancel := context.WithCancel(context.Background()) | ||
| c.cancelUpdateTTL = cancel | ||
| go func() { | ||
| if err := c.consulClient.Agent().UpdateTTL(c.opts.check.CheckID, "online", api.HealthPassing); err != nil { |
There was a problem hiding this comment.
另外还应该评估下 Deregister 时 是否有必要主动停止这里的 更新，如果 调用 Deregister 但是距离真正服务停止还有一段时间，是否会有时间空隙，然后客户端会获取到这个准备下线的实例，去请求却又请求不到 造成失败。这种可以评估一下。
