Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for posting an updated resource #22

Open
wants to merge 4 commits into
base: 1.x
Choose a base branch
from

Conversation

massmediagroup-87
Copy link

@massmediagroup-87 massmediagroup-87 commented Jan 31, 2020

Hello!

I've tried to translate component but there is some hardcoded text which can be translated.
so, I added translations into js

These changes make it possible to translate a message that pops up after a resource has been updated.

It would be nice to have it merged, they may be helpful.

@brandonferens
Copy link
Member

@massmediagroup-87 Thank you for this. I will review as soon as I get a chance.

@4n70w4
Copy link
Contributor

4n70w4 commented Feb 6, 2020

Probably you need to create a file with a translation into en to en.
As a template for creating translations.

@brandonferens
Copy link
Member

Agreed @4n70w4. It would be good to add a translation config to this package.

@massmediagroup-87 please update your code as it is out-of-date. And include a publishable config for language files. Please try to duplicate the code style in the package.

@Paulsky Paulsky mentioned this pull request May 20, 2020
@brandonferens brandonferens changed the base branch from master to 1.x May 20, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation
4 participants