Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded Corners Mask #6

Open
smxthereisonlyone opened this issue Oct 9, 2019 · 5 comments
Open

Rounded Corners Mask #6

smxthereisonlyone opened this issue Oct 9, 2019 · 5 comments

Comments

@smxthereisonlyone
Copy link

Can you please add that the shader can be applied to a mask as well and not only to the masked image?

@kirevdokimov
Copy link
Owner

Hi @smxthereisonlyone!
The idea sounds good, but unfortunately, masks in Unity works via stencil which does not support soft cut, so I am not sure it is possible to easily add this functionality to shaders without inventing new different approaches. It also will impact performance harder.

@jlankitus
Copy link

this would be super useful! What's odd is that in editor this actually kinda works, but the corners are seen glitching back and forth. So close yet so far. Awesome asset though btw.

@ArthurD
Copy link
Contributor

ArthurD commented Mar 16, 2023

It appears to work if you make 1 change to the shaders. Works as expected for me, on macOS, at least.

See attached screenshot.

Highlighted lines = newly-added code.

Screenshot 2023-03-16 at 4 42 25 PM

@ArthurD
Copy link
Contributor

ArthurD commented Mar 17, 2023

Went ahead and added a PR that makes this work. :)

@CSEliot
Copy link

CSEliot commented Jun 5, 2023

@kirevdokimov or @smxthereisonlyone wanna mark this as resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants