Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for Vimeo and DailyMotion links/bookmarks #6

Open
kingsman142 opened this issue Feb 11, 2020 · 0 comments
Open

Provide support for Vimeo and DailyMotion links/bookmarks #6

kingsman142 opened this issue Feb 11, 2020 · 0 comments

Comments

@kingsman142
Copy link
Owner

kingsman142 commented Feb 11, 2020 •
edited
Loading

Currently, the extension specifically only searches for YouTube links. As such, even if a video/music player is on Vimeo or DailyMotion or any other video streaming platform, they are ignored. Add support so those additional links can be added into the functionality of the extension.

  • Requires modifying "permissions" in the manifest for cross-site scripting for the new platforms
  • Requires refactoring code to make it generalizable (so it doesn't just work on youtube links, i.e. getting the current timestamp we're at in the video)
@kingsman142 kingsman142 changed the title Provide support for non-YouTube links/bookmarks Provide support for Vimeo and DailyMotion links/bookmarks Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kingsman142