Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: setting zero as default minute/ #50

Open
tomsoderlund opened this issue Dec 5, 2017 · 0 comments
Open

Bug: setting zero as default minute/ #50

tomsoderlund opened this issue Dec 5, 2017 · 0 comments

Comments

@tomsoderlund
Copy link

tomsoderlund commented Dec 5, 2017

Hi! Thanks for a great directive!

Here's a bug:

https://github.com/kineticsocial/angularjs-datetime-picker/blob/master/angularjs-datetime-picker.js#L235

var minute = scope.minute || today.getMinutes();

If scope.minute is zero, it will take today.getMinutes() instead. So setting minute="0" on the directive won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant